Add descriptions and categories to Timeline configurations#1953
Merged
Conversation
devoncarew
approved these changes
May 12, 2020
Contributor
There was a problem hiding this comment.
lgtm
I'd try to make the descriptions fit in one line where possible (where it does't make them more confusing), and err towards understandability to the user even if the descriptions are slightly less technically correct. Some suggestions below (but please feel free to iterate):
- Dart: Events emitted from dart:developer Timeline (including Flutter framework events)
- Embedder: Additional platform events (often emitted from the Flutter engine)
- GC: Garbage collection
- API: Calls to the VM embedding API
- Compiler: Compiler phases (loading code, compilation, optimization, etc.)
- CompilerVerbose: More detailed compiler phases
- Debugger: Debugger paused events
- Isolate: Isolate events (startup, shutdown, snapshot loading, etc.)
- VM: Dart VM events (startup, shutdown, snapshot loading, etc.)
| // the distinction, however. | ||
| _buildStream( | ||
| name: 'Network', | ||
| description: ' • Log Http traffic', |
Contributor
There was a problem hiding this comment.
Just Http traffic? or HTTP traffic? Not sure if we need the all caps case
Member
Author
|
Incorporated suggestions and expanded the width of the dialog to make items fit on one line: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Splits streams into a default and advanced section, and adds some descriptions provided by @rmacnak-google.